Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(server)!: remove duplicate bech32 prefix endpoint #18909

Merged
merged 2 commits into from
Dec 28, 2023
Merged

refactor(server)!: remove duplicate bech32 prefix endpoint #18909

merged 2 commits into from
Dec 28, 2023

Conversation

tac0turtle
Copy link
Member

Description

This pr removes bech32prefix endpoint from grpc refelction in server. This removes the global usage of bech32 and puts it into auth. Auth already had an endpointt that was used elsewhere.

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • reviewed "Files changed" and left comments if necessary
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • updated the relevant documentation or specification, including comments for documenting Go code
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic, API design and naming, documentation is accurate, tests and test coverage

@github-actions github-actions bot added C:x/tx C:Hubl Tool: Hubl labels Dec 28, 2023
@tac0turtle tac0turtle marked this pull request as ready for review December 28, 2023 02:53
@tac0turtle tac0turtle requested a review from a team as a code owner December 28, 2023 02:53
@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 28, 2023 •
edited
Loading

Walkthrough

The recent updates reflect a simplification of the Cosmos reflection service by removing the ConfigurationDescriptor message and related RPCs. There's a shift in the gRPC client interface handling within internal tools, opting for a different package and adapting to the new response format. Additionally, there's a refinement in the protobuf definition for a nested message structure, which does not affect the control flow but alters the message's schema.

Changes

File Path Change Summary
.../base/reflection/v2alpha1/reflection.proto Removed ConfigurationDescriptor and associated RPCs; added reserved field to AppDescriptor.
.../reflection/v2alpha1/reflection.go Removed GetConfigurationDescriptor method from server implementation.
.../hubl/internal/load.go Updated gRPC client imports and usage; modified response handling in getAddressPrefix.
.../testpb/signers.proto Modified DeeplyNestedRepeatedSigner message schema.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat with CodeRabbit Bot (@coderabbitai)

Note: Auto-reply has been disabled for this repository by the repository owner. The CodeRabbit bot will not respond to your comments unless it is explicitly tagged.

  • You can tag CodeRabbit on specific lines of code or entire files in the PR by tagging @coderabbitai in a comment. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • You can tag @coderabbitai in a PR comment and ask questions about the PR and the codebase. Examples:
    • @coderabbitai generate interesting stats about this repository from git and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid.
    • @coderabbitai read the files in the src/scheduler package and generate README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

@tac0turtle
refactor(server)!: remove duplicate bech32 prefix endpoint
1aad1b2 
This pr removes bech32prefix endpoint from grpc refelction in server. This removes the global usage of bech32 and puts it into auth. Auth already had an endpointt that was used elsewhere.
facundomedica
facundomedica approved these changes Dec 28, 2023
View reviewed changes
Copy link
Member

@facundomedica facundomedica left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK. I'm not familiar with the uses of this but I'm all in for de-duplication

julienrbrt
julienrbrt reviewed Dec 28, 2023
View reviewed changes
proto/cosmos/base/reflection/v2alpha1/reflection.proto Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we ok with those proto breaking changes? If we keep that global api module, we should deprecate things here instead of outright removing them.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i can deprecate and return an error to look for auth.

coderabbitai[bot]
coderabbitai bot reviewed Dec 28, 2023
View reviewed changes
server/grpc/reflection/v2alpha1/reflection.go
@@ -47,7 +47,7 @@ func (r reflectionServiceServer) GetCodecDescriptor(_ context.Context, _ *GetCod
}

func (r reflectionServiceServer) GetConfigurationDescriptor(_ context.Context, _ *GetConfigurationDescriptorRequest) (*GetConfigurationDescriptorResponse, error) {
return &GetConfigurationDescriptorResponse{Config: r.desc.Configuration}, nil
return nil, errors.New("this endpoint has been depreacted, please see auth/Bech32Prefix for the data you are seeking")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The GetConfigurationDescriptor function has been modified to return an error, indicating the endpoint is deprecated. This change is in line with the PR's objective to remove the redundant bech32prefix endpoint. Ensure that this deprecation does not affect clients that may still be calling this endpoint.

julienrbrt
julienrbrt approved these changes Dec 28, 2023
View reviewed changes
Copy link
Member

@julienrbrt julienrbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@tac0turtle tac0turtle added this pull request to the merge queue Dec 28, 2023
Merged via the queue into main with commit b720cc7 Dec 28, 2023
59 of 60 checks passed
@tac0turtle tac0turtle deleted the marko/remove_duplicate_bech32 branch December 28, 2023 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

@julienrbrt julienrbrt julienrbrt approved these changes

@facundomedica facundomedica facundomedica approved these changes

Assignees

@facundomedica facundomedica

@julienrbrt julienrbrt

@atheeshp atheeshp

Labels
C:Hubl Tool: Hubl C:x/tx
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tac0turtle @facundomedica @julienrbrt @atheeshp